-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqllab): Replace FilterableTable by AgGrid Table #29900
base: master
Are you sure you want to change the base?
feat(sqllab): Replace FilterableTable by AgGrid Table #29900
Conversation
@justinpark this looks great! I think I might have asked this question before, so apologies if I did, but for how long custom table settings are kept - just for session and just for this specific query? |
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.160.157.54:8080. Credentials are |
You're right. This will only apply to the current query in the current session. I considered saving it, but I thought it might be better not to, as revisiting the query later when the memory has faded could cause confusion with different items being displayed in the query results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29900 +/- ##
===========================================
+ Coverage 60.48% 70.78% +10.29%
===========================================
Files 1931 1985 +54
Lines 76236 79965 +3729
Branches 8568 9146 +578
===========================================
+ Hits 46114 56601 +10487
+ Misses 28017 21139 -6878
- Partials 2105 2225 +120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superset-frontend/package.json
Outdated
@@ -126,6 +126,8 @@ | |||
"@visx/xychart": "^3.5.1", | |||
"abortcontroller-polyfill": "^1.7.5", | |||
"ace-builds": "^1.35.4", | |||
"ag-grid-community": "31.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the latest 32.2 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
e5d9e67
to
c4ae211
Compare
when is the release target date and release version ? |
SUMMARY
Following up #27645, This commit includes the migration of the component used for SQLLab results from the ant-table component to the ag-grid component.
During this process, the existing logic(
getWidthsForColumns
) that measured column size to adjust the width was removed because it was not only performance-intensive but also unnecessary, as the resizable column option in ag-grid allows users to adjust the width as needed.Additionally, other property options were modified to ensure compatibility with ag-grid. Moreover, a column menu feature was added, enabling users to pin specific columns and apply filters.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Header menu (Actions):
TESTING INSTRUCTIONS
Go to SQL Lab and run a query to explore the data
ADDITIONAL INFORMATION