docs: HTML embedding of charts/dashboards without authentication #30032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using Flask-OIDC
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Answering the question of @kormpakis made me aware that I forgot to include this.
sfirke
requested changes
Aug 28, 2024
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
sfirke
approved these changes
Sep 18, 2024
|
Thanks @lindner-tj ! Sorry for the slow re-review. |
@sfirke no worries, thank you for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Was trying to figure out how to embed dashboards/charts in other websites without SDK, came across this: #28407 I got it working and thought it would be a great addition to the docs.
PR is specifically for docs/docs/configuration/networking-settings.mdx
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Add frame ancestors to Flask Talisman CSP, restart Superset and embed whatever public dashboard/chart you like
ADDITIONAL INFORMATION