-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OAuth2 database field #30126
feat: OAuth2 database field #30126
Conversation
@@ -161,23 +161,20 @@ export const httpPathField = ({ | |||
getValidation, | |||
validationErrors, | |||
db, | |||
}: FieldPropTypes) => { | |||
console.error(db); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this.
345d079
to
fbeeb5a
Compare
1cff541
to
cea5d85
Compare
/testenv up |
@sadpandajoe Ephemeral environment spinning up at http://34.222.11.9:8080. Credentials are |
}: { | ||
target: HTMLInputElement; | ||
}) => | ||
onChange(ActionType.EncryptedExtraInputChange, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was surprised it didn't exist yet!
5885a39
to
5fd7e21
Compare
cea5d85
to
46a42e1
Compare
46a42e1
to
0ac5b62
Compare
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
More work on Snowflake OAuth2 (this PR depends on #30082). This PR introduces a new field for the database configuration modal, allowing OAuth2 client information to be provided by the user:
The component combines the 5 different input fields, and then passes them inside the
masked_encrypted_extra
attribute on database CRUD:(Note that ideally we would pass these in the
parameters
field, and let the DB engine spec build the object inencrypted_extra
. But thebuild_sqlalchemy_uri
method — as the name suggests — only builds an URI, so we would have to modify it to return a tuple with(uri, connect_args)
if we passed them client information insideparameters
, and also figure out a way to inform that these fields should be stored inencrypted_extra
, notextra
, so for now the frontend does the work. I left a small TODO for me to fix this in the future.)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See above.
TESTING INSTRUCTIONS
Adding tests.
ADDITIONAL INFORMATION