fix(Dashboard download): Download dashboard screenshot/PDF using SupersetClient #30212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When downloading the dashboard as a screenshot/PDF via the client, a
POST
request is sent to/api/v1/dashboard/cache_dashboard_screenshot/
, and then a followingGET
request has to be sent to/api/v1/dashboard/${dashboardId}/screenshot/${cacheKey}/?download_format=${format}
.This PR changes the
GET
request to be fired withSupersetClient
as opposed tofetch
, to make sure that theGUEST_TOKEN_HEADER_NAME
header is included in the request (for guest users).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION