Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Celery): Pass guest_token as user context is not available in Celery #30224

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix(Celery): Pass guest_token as user context is not available in Celery #30224

merged 3 commits into from
Sep 11, 2024

Conversation

geido
Copy link
Member

@geido geido commented Sep 10, 2024

SUMMARY

The original PR has failed to address the missing user context in Celery #30200. This fixes it

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Downloading a screenshot should work for Embedded

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Sep 10, 2024
@dosubot dosubot bot added change:backend Requires changing the backend embedded labels Sep 10, 2024
@github-actions github-actions bot removed the embedded label Sep 10, 2024
Vitor-Avila
Vitor-Avila approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Vitor-Avila Vitor-Avila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on further testing this today, but it looks great from a code perspective!

@geido geido merged commit 1b34ad6 into master Sep 11, 2024
33 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 11, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 11, 2024
@geido @sadpandajoe
fix(Celery): Pass guest_token as user context is not available in Cel…
789ca73 
…ery (#30224)

(cherry picked from commit 1b34ad6)
@rusackas rusackas deleted the geido/fix/guest-user-celery branch September 27, 2024 20:54
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitor-Avila Vitor-Avila Vitor-Avila approved these changes

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @Vitor-Avila @mistercrunch @sadpandajoe