Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Screenshot): Dashboard screenshot cache key to include state #30265

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(Screenshot): Dashboard screenshot cache key to include state #30265

merged 1 commit into from
Sep 16, 2024

Conversation

geido
Copy link
Member

@geido geido commented Sep 13, 2024

SUMMARY

The Dashboard screenshot cache key wasn't including the Dashboard state which causes the cache key to always return cached screenshots even when a different tab anchor was selected.

TESTING INSTRUCTIONS

  1. Take a screenshot of a Dashboard
  2. Change tab, take another screenshot
  3. The screenshot should depict the tab you have selected

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Sep 13, 2024
@dosubot dosubot bot added dashboard:tab Related to the usage of tabs in the Dashboard infra:caching Infra setup and configuration related to caching labels Sep 13, 2024
@geido geido merged commit 0679454 into master Sep 16, 2024
35 of 37 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 16, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 16, 2024
@geido @sadpandajoe
fix(Screenshot): Dashboard screenshot cache key to include state (#30265
35de980 
)

(cherry picked from commit 0679454)
@rusackas rusackas deleted the geido/fix/dashnboard-screenshot-cache branch September 16, 2024 17:19
@rusackas
Copy link
Member

Might this relate to the issue with dashboard thumbnails not appearing in the Dashboard list view?

@villebro
Copy link
Member

Btw, it would have been nice to add a test for this

@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

@eschutho eschutho Awaiting requested review from eschutho

@Vitor-Avila Vitor-Avila Awaiting requested review from Vitor-Avila

Assignees
No one assigned
Labels
api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:tab Related to the usage of tabs in the Dashboard infra:caching Infra setup and configuration related to caching size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geido @rusackas @villebro @Antonio-RiveroMartnez @mistercrunch @sadpandajoe