Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install/docker): use zstd-baked image for building superset-frontend in containerized env #30279

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix(install/docker): use zstd-baked image for building superset-frontend in containerized env #30279

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c178264
fix(install/docker): install zstd for building superset-frontend in c…
hainenber Sep 14, 2024
21d5c4c
fix: remove trailing whitespaces per pre-commit hook
hainenber Sep 14, 2024
abb396b
fix(install/docker): use zstd-baked image for building superset-node
hainenber Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,14 @@ services:
disable: true

superset-node:
image: node:20
build:
context: .
target: superset-node
args:
# This prevents building the frontend bundle since we'll mount local folder
# and build it on startup while firing docker-frontend.sh in dev mode, where
# it'll mount and watch local files and rebuild as you update them
DEV_MODE: "true"
environment:
# set this to false if you have perf issues running the npm i; npm run dev in-docker
# if you do so, you have to run this manually on the host, which should perform better!
Expand Down
Loading