Improve superset list view content layout #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2017 15:21
- less header spaces and stacks - move pagination down to bottom - apply material design style to 'add' action button - will apply to all superset list view, like slices list, security tab lists etc.
- less header spaces and stacks - move pagination down to bottom - apply material design style to 'add' action button - will apply to all superset list view, like slices list, security tab lists etc.
xrmx
reviewed
Jun 24, 2017
| checkSearchButton(); | ||
| }); | ||
|
|
||
| (function($) { |
There was a problem hiding this comment.
not sure which line you mean to use tabs. But it seems all superset code base used spaces not tabs for line indentation.
There was a problem hiding this comment.
I mean you are using tabs instead of spaces :)
added 3 commits
June 26, 2017 11:00
- less header spaces and stacks - move pagination down to bottom - apply material design style to 'add' action button - will apply to all superset list view, like slices list, security tab lists etc.
- less header spaces and stacks - move pagination down to bottom - apply material design style to 'add' action button - will apply to all superset list view, like slices list, security tab lists etc.
- less header spaces and stacks - move pagination down to bottom - apply material design style to 'add' action button - will apply to all superset list view, like slices list, security tab lists etc.
xrmx
reviewed
Jun 28, 2017
| function checkSearchButton() { | ||
| var hasFilter = $('.filters tr').length; | ||
| if (hasFilter) { | ||
| $('.filters a.remove-filter').off('click', checkSearchButton); |
|
Changes Unknown when pulling 8fa4b2b0b03006da087dbc4241dca26cc0de66de on graceguo-supercat:gg-SlicesTemplate into ** on apache:master**. |
|
This PR doesn't look right... 76 files changed? |
graceguo-supercat
force-pushed
the
gg-SlicesTemplate
branch
from
8fa4b2b
to
4a308cf
Compare
2 similar comments
mistercrunch
approved these changes
Aug 10, 2017
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superset has a few pages that were using default template provided by AppBuilder framework.
One problem with this layout is that title, filter, pagination are all stacked row by row, which took a lot of space before actual list content. So we want to make a new list view layout, to make top section cleaner and keep all the existed functionalities.
