-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove flaky test #30395
base: master
Are you sure you want to change the base?
chore: remove flaky test #30395
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -312,15 +312,15 @@ describe('Native filters', () => { | |
}); | ||
|
||
describe('Nativefilters initial state not required', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of skipping each test, i believe if you did a |
||
it("User can check 'Filter has default value'", () => { | ||
it.skip("User can check 'Filter has default value'", () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_name', column: 'country_name', datasetId: 2 }, | ||
]); | ||
enterNativeFilterEditModal(); | ||
inputNativeFilterDefaultValue(testItems.filterDefaultValue); | ||
}); | ||
|
||
it('User can add a new native filter', () => { | ||
it.skip('User can add a new native filter', () => { | ||
prepareDashboardFilters([]); | ||
|
||
let filterKey: string; | ||
|
@@ -345,7 +345,7 @@ describe('Native filters', () => { | |
cy.get(nativeFilters.modal.container).should('not.exist'); | ||
}); | ||
|
||
it('User can restore a deleted native filter', () => { | ||
it.skip('User can restore a deleted native filter', () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_code', column: 'country_code', datasetId: 2 }, | ||
]); | ||
|
@@ -363,7 +363,7 @@ describe('Native filters', () => { | |
); | ||
}); | ||
|
||
it('User can create a time grain filter', () => { | ||
it.skip('User can create a time grain filter', () => { | ||
prepareDashboardFilters([]); | ||
enterNativeFilterEditModal(); | ||
fillNativeFilterForm( | ||
|
@@ -424,7 +424,7 @@ describe('Native filters', () => { | |
validateFilterContentOnDashboard(testItems.topTenChart.filterColumnYear); | ||
}); | ||
|
||
it('User can create a numerical range filter', () => { | ||
it.skip('User can create a numerical range filter', () => { | ||
visitDashboard(); | ||
enterNativeFilterEditModal(false); | ||
fillNativeFilterForm( | ||
|
@@ -454,7 +454,7 @@ describe('Native filters', () => { | |
}); | ||
}); | ||
|
||
it('User can undo deleting a native filter', () => { | ||
it.skip('User can undo deleting a native filter', () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_name', column: 'country_name', datasetId: 2 }, | ||
]); | ||
|
@@ -465,7 +465,7 @@ describe('Native filters', () => { | |
.should('have.attr', 'value', testItems.topTenChart.filterColumn); | ||
}); | ||
|
||
it('User can cancel changes in native filter', () => { | ||
it.skip('User can cancel changes in native filter', () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_name', column: 'country_name', datasetId: 2 }, | ||
]); | ||
|
@@ -479,7 +479,7 @@ describe('Native filters', () => { | |
cy.contains('You have removed this filter.').should('be.visible'); | ||
}); | ||
|
||
it('User can create a value filter', () => { | ||
it.skip('User can create a value filter', () => { | ||
visitDashboard(); | ||
enterNativeFilterEditModal(false); | ||
addCountryNameFilter(); | ||
|
@@ -490,7 +490,7 @@ describe('Native filters', () => { | |
validateFilterNameOnDashboard(testItems.topTenChart.filterColumn); | ||
}); | ||
|
||
it('User can apply value filter with selected values', () => { | ||
it.skip('User can apply value filter with selected values', () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_name', column: 'country_name', datasetId: 2 }, | ||
]); | ||
|
@@ -502,7 +502,7 @@ describe('Native filters', () => { | |
}); | ||
}); | ||
|
||
it('User can stop filtering when filter is removed', () => { | ||
it.skip('User can stop filtering when filter is removed', () => { | ||
prepareDashboardFilters([ | ||
{ name: 'country_name', column: 'country_name', datasetId: 2 }, | ||
]); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ | |
*/ | ||
import { CHART_LIST } from 'cypress/utils/urls'; | ||
import { interceptGet as interceptDashboardGet } from 'cypress/e2e/dashboard/utils'; | ||
import { FORM_DATA_DEFAULTS, NUM_METRIC } from './visualizations/shared.helper'; | ||
Check failure on line 21 in superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js GitHub Actions / frontend-build
Check failure on line 21 in superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js GitHub Actions / frontend-build
Check failure on line 21 in superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js GitHub Actions / frontend-build
|
||
import { | ||
interceptFiltering, | ||
saveChartToDashboard, | ||
|
@@ -98,7 +98,7 @@ | |
cy.wait('@filtering'); | ||
}); | ||
|
||
it('should show the cross-referenced dashboards', () => { | ||
it.skip('should show the cross-referenced dashboards', () => { | ||
visitSampleChartFromList('1 - Sample chart'); | ||
|
||
cy.getBySel('metadata-bar').contains('Not added to any dashboard'); | ||
|
@@ -122,32 +122,32 @@ | |
}); | ||
}); | ||
|
||
describe('No Results', () => { | ||
beforeEach(() => { | ||
cy.intercept('POST', '/superset/explore_json/**').as('getJson'); | ||
}); | ||
|
||
it('No results message shows up', () => { | ||
const formData = { | ||
...FORM_DATA_DEFAULTS, | ||
metrics: [NUM_METRIC], | ||
viz_type: 'line', | ||
adhoc_filters: [ | ||
{ | ||
expressionType: 'SIMPLE', | ||
subject: 'state', | ||
operator: 'IN', | ||
comparator: ['Fake State'], | ||
clause: 'WHERE', | ||
sqlExpression: null, | ||
}, | ||
], | ||
}; | ||
|
||
cy.visitChartByParams(formData); | ||
cy.wait('@getJson').its('response.statusCode').should('eq', 200); | ||
cy.get('div.chart-container').contains( | ||
'No results were returned for this query', | ||
); | ||
}); | ||
}); | ||
// describe('No Results', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can do a describe.skip here to skip all these tests |
||
// beforeEach(() => { | ||
// cy.intercept('POST', '/superset/explore_json/**').as('getJson'); | ||
// }); | ||
|
||
// it('No results message shows up', () => { | ||
// const formData = { | ||
// ...FORM_DATA_DEFAULTS, | ||
// metrics: [NUM_METRIC], | ||
// viz_type: 'line', | ||
// adhoc_filters: [ | ||
// { | ||
// expressionType: 'SIMPLE', | ||
// subject: 'state', | ||
// operator: 'IN', | ||
// comparator: ['Fake State'], | ||
// clause: 'WHERE', | ||
// sqlExpression: null, | ||
// }, | ||
// ], | ||
// }; | ||
|
||
// cy.visitChartByParams(formData); | ||
// cy.wait('@getJson').its('response.statusCode').should('eq', 200); | ||
// cy.get('div.chart-container').contains( | ||
// 'No results were returned for this query', | ||
// ); | ||
// }); | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing all the skips here and below, you can just do
it.only
and it'll only run that test above. You can probably put a note after that test to list out why you're skipping all these other tests