chore: run cypress headless in ci #30426
Conversation
eschutho
force-pushed
the
elizabeth/cypress-headless
branch
from
16b736c
to
4679b0c
Compare
| @@ -61,7 +63,7 @@ def run_cypress_for_test_file( | |||
| os.environ.pop("CYPRESS_RECORD_KEY", None) | |||
| cmd = ( | |||
| f"{XVFB_PRE_CMD} " | |||
| f"{cypress_cmd} --browser {browser} " | |||
| f"{cypress_cmd} --browser {browser} --headless " | |||
There was a problem hiding this comment.
I was testing to see if that was the case, but so far haven't seen any test failures related to it. I think it should be able to take screenshots headlessly, is my guess. This is actually the default flag, so this may already be running headlessly.
| @@ -44,7 +44,9 @@ def run_cypress_for_test_file( | |||
| os.environ["TERM"] = "xterm" | |||
| os.environ["ELECTRON_DISABLE_GPU"] = "true" | |||
| build_id = generate_build_id() | |||
| browser = os.getenv("CYPRESS_BROWSER", "chrome") | |||
| browser = os.getenv("CYPRESS_BROWSER", "electron") | |||
There was a problem hiding this comment.
a bit concerned to bring yet another engine in the mix, specifically for tests/automation. Supporting two is already a challenge, and thinking now that we should just pick one engine, either Chrome or Firefox, and use is consistently for thumbnail-generation, alert & reports and in e2e tests
There was a problem hiding this comment.
Also confused about what electron --headless means, isn't electron a "head" by definition? Did a tiny bit of research just now, and Electron uses Blink (a fork of webkit), Chrome/Chromium use Blink as well, and FF uses Gecko. So chrome/chromium/electron in headless more should be pretty much the same AFAIK
|
Closing this as per the concerns about having a third engine in the mix. |
SUMMARY
Fixes CI for cypress by running it in headless mode.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION