fix(Filters): Apply native & cross filters on common columns

[geido]

SUMMARY

When in scope (global or specific) charts that are not applicable to the filter (do not share the same datasource or columns) were being applied anyway, causing unnecessary queries. This PR checks that the charts have columns in common or will exclude the charts.

AFTER

COVID.Vaccine.Dashboard.mp4

COVID.Vaccine.Dashboard.1.mp4

TESTING INSTRUCTIONS

1. Create a native filter that has no common columns with a chart
2. Add the chart in scope
3. Apply the filter
4. The chart should not reload and emit a query

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://35.90.248.247:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

Just realized that highlighting a filter that is not applicable should also be added as an enhancement for this PR. Working on that.

[geido]

Holding on this while testing more cases

[michael-s-molina]

Some things I observed while testing

Screen.Recording.2024-10-09.at.14.52.06.mov

• The first 2 charts should be affected by the filter but there's no filter indicator
• If you check the query, the filter was applied but the chart was not reloaded

I noticed this behavior only happens when you create a dashboard and go add filters. If you load a dashboard from the dashboard list, then these bugs disappear.

[michael-s-molina]

In this example, the last 2 charts are from different datasets but both have a gender column. Initially, the filter is correctly applied to both datasets but if I remove the last chart from the filter scope, it's still being affected.

Screen.Recording.2024-10-09.at.15.08.23.mov

[michael-s-molina]

I found some problems while testing with the ephemeral environment.

[geido]

I found some problems while testing with the ephemeral environment.

Thanks @michael-s-molina, I could not see many of these issues locally due to #30569 as I was under the false impression that I was testing the latest state of the code. I reverted that PR and now looking at these problems. Thanks for catching them!

[yousoph]

/testenv up

[github-actions]

@yousoph Ephemeral environment spinning up at http://34.214.222.103:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.