Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin/echarts): correct enum values for LABEL_POSITION map #30509

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(plugin/echarts): correct enum values for LABEL_POSITION map #30509

merged 1 commit into from
Oct 3, 2024

Conversation

hainenber
Copy link
Contributor

fix(plugin/echarts): correct enum values for LABEL_POSITION map

SUMMARY

Fixes #30435
Fix duplicate enum used in LABEL_POSITION map

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue: 30435
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
fix(plugin/echarts): correct enum value for LABEL_POSITION
8b401c8 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the viz:charts:echarts Related to Echarts label Oct 3, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Oct 3, 2024
@rusackas rusackas merged commit 989744a into apache:master Oct 3, 2024
36 of 37 checks passed
@hainenber hainenber deleted the fix-invalid-label-position-enum branch October 4, 2024 01:04
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
plugins size/XS viz:charts:echarts Related to Echarts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The LABEL_POSITION value is invalid.
3 participants
@hainenber @michael-s-molina @rusackas