Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarification on which command to use on which Ubuntu version. #30523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkovacs
Copy link

@kkovacs kkovacs commented Oct 5, 2024

SUMMARY

Clarification on which command to use on which Ubuntu version.

ADDITIONAL INFORMATION

None.

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Oct 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title Clarification on which command to use on which Ubuntu version. docs: Clarification on which command to use on which Ubuntu version. Oct 7, 2024

```bash
sudo apt-get install build-essential libssl-dev libffi-dev python-dev python-pip libsasl2-dev libldap2-dev default-libmysqlclient-dev
```

In Ubuntu 20.04 the following command will ensure that the required dependencies are installed:
In Ubuntu **20.04 and 22.04** the following command will ensure that the required dependencies are installed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if it's a Ubuntu version that is not in the range? Maybe add this additional context.

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed but thanks for clarifying this, it will be an improvement!


```bash
sudo apt-get install build-essential libssl-dev libffi-dev python-dev python-pip libsasl2-dev libldap2-dev default-libmysqlclient-dev
```

In Ubuntu 20.04 the following command will ensure that the required dependencies are installed:
In Ubuntu **20.04 and 22.04** the following command will ensure that the required dependencies are installed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkovacs could you also switch it to have it first say what to do for version 20.04+, then after that say what to do for <20.04? Most people will be installing with 20.04+ at this point so that instruction should come first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants