fix(Jinja): Extra cache keys to consider vars with set

[geido]

SUMMARY

The regex for ExtraCache that checks whether the statement has extra cache key calls via has_extra_cache_key_calls wasn't considering cases where the callable vars might not be in double curly brackets, such as:

{% set customer_id = current_user_email() %}
select '{{customer_id}}' as test;

Because of this issue, cached queries for charts would show previously cached data potentially exposing information from other users.

TESTING INSTRUCTIONS

1. Create a dataset using

{% set customer_id = current_user_email() %}
select '{{customer_id}}' as test;

2. Create a table chart based on the dataset
3. Add the chart to a Dashboard
4. Login with another user
5. You should see the current user email

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Great catch! I don't agree with removing the check for the opening bracket - let's rather make it check for both.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://34.222.13.11:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

This comment looks mildly concerning.. Although to be fair, this probably isn't a problem in practice.

[villebro]

Beautiful test refactoring! ❤️ LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.