Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): overhaul Babel usage in superset-frontend #30552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

build(deps-dev): overhaul Babel usage in superset-frontend #30552

wants to merge 3 commits into from
+1,187 −1,009

Conversation

hainenber
Copy link
Contributor

SUMMARY

Update core Babel packages to latest version (v7.25.7) and remove obsolete Babel plugins/configs that are already included in newer @babel/preset-env.

I only removed ones with proper banner. For example, @babel/plugin-proposal-private-methods

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI should pass, especially frontend-build

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
build(deps-dev): remove unused babel-node
f14bf22 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
build(deps-dev): upgrade core Babel packages to latest v7.25.7
42d6add 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
chore(cfg): remove Babel plugins for ES2020+ proposals
1f2d72f 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Oct 8, 2024
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas Awaiting requested review from rusackas

@justinpark justinpark Awaiting requested review from justinpark

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dependencies:npm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @michael-s-molina