Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update html rendering to true from false #30565

Conversation

sadpandajoe
Copy link
Member

SUMMARY

In Superset 4.0, we used to render html in SQL Lab, but with #27969, we added the option to not render html at all. However, as part of the PR, it is defaulting to false vs defaulting to true which is the existing behavior users are expecting.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sadpandajoe
Copy link
Member Author

/testenv up

Copy link
Contributor

github-actions bot commented Oct 9, 2024

@sadpandajoe Ephemeral environment spinning up at http://34.222.140.49:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@sadpandajoe
Copy link
Member Author

/testenv up

Copy link
Contributor

github-actions bot commented Oct 9, 2024

@sadpandajoe Ephemeral environment spinning up at http://54.201.170.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

@sadpandajoe Ephemeral environment spinning up at http://54.185.164.57:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@sadpandajoe sadpandajoe marked this pull request as ready for review October 9, 2024 22:35
@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Oct 9, 2024
@michael-s-molina michael-s-molina added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 10, 2024
@michael-s-molina michael-s-molina merged commit ef0ede7 into apache:master Oct 10, 2024
61 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:draft size/XS sqllab Namespace | Anything related to the SQL Lab v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
Status: Cherried
Development

Successfully merging this pull request may close these issues.

3 participants