Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] Split large reducer logic in ExploreViewContainer #3088

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jul 5, 2017

Step 1 for refactoring Dashboard view.

We want to isolate a few sub-components and its actions/reducers from Explore view, so that we can reuse the same chart render component for Dashboard view. In this PR, I split the big Explore reducer into 3 smaller reducers to handle chart update actions, slice saveas/overwrite actions, and explore view actions accordingly.

Here is a reference for why and how to split reducer logic.

@coveralls
Copy link

coveralls commented Aug 7, 2017

Coverage Status

Coverage remained the same at 69.311% when pulling cf66782 on graceguo-supercat:gg-ExploreViewSplitReducerLogic into f68189b on apache:master.

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage remained the same at 69.311% when pulling 08a0e07 on graceguo-supercat:gg-ExploreViewSplitReducerLogic into f68189b on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.311% when pulling 08a0e07 on graceguo-supercat:gg-ExploreViewSplitReducerLogic into f68189b on apache:master.

@mistercrunch mistercrunch merged commit b3107bb into apache:master Aug 10, 2017
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 10, 2017
)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
@graceguo-supercat graceguo-supercat deleted the gg-ExploreViewSplitReducerLogic branch August 10, 2017 22:11
mistercrunch pushed a commit that referenced this pull request Aug 11, 2017
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* improve test coverage for explore view components:
- SaveModal component
- URLShortLinkButton

* remove comment-out code

* [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (#3254)

* [explore] make edit datasource a basic link (#3244)

* Relying on FAB for font-awesome.min.css (#3261)

* Modernize SQLA pessimistic handling (#3256)

Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.

* [webpack] break CSS and JS files while webpackin' (#3262)

* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue

* import logging (#3264)

* [bugfix] preserve order in groupby (#3268)

Recently in
4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.

* Explicitly add Flask as dependancy (#3252)

* Use sane Celery defaults to prevent tasks from being delayed (#3267)

* Improve the chart type of Visualize in sqllab (#3241)

* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter

* Set default ports Druid (#3266)

For Druid set the default port for the broker and coordinator.

* [explore] Split large reducer logic in ExploreViewContainer (#3088)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
mistercrunch added a commit to mistercrunch/superset that referenced this pull request Aug 12, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants