Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(List): Upgrade List from antdesign4 to antdesign5 #30963

Merged

Conversation

alexandrusoare
Copy link
Contributor

SUMMARY

Upgrade List from antdesign4 to antdesign5
Fixes #30909

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
before

After
after

Before
before_1

After
after_1

TESTING INSTRUCTIONS

Run the unit tests and do visual comparison between versions.

The first list you find it by going to Charts -> select a chart -> in the Control Panel there should be an Annotation Layers (some charts may not have it, depends on the visualization I think)
The second list you find it in Charts as well -> select a random chart -> for visualization go to table and choose Time-Series Table -> after that at Query -> go to the Time Series columns

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Nov 18, 2024
@sadpandajoe sadpandajoe requested a review from geido November 19, 2024 16:52
@sadpandajoe sadpandajoe added the hold! On hold label Nov 19, 2024
@geido geido added the preset:bounty Issues that have been selected by Preset and have a bounty attached. label Nov 21, 2024
@geido
Copy link
Member

geido commented Nov 21, 2024

Hey @alexandrusoare thanks for the contribution, I think there is a minor cosmetic issue when dragging

Untitled

@geido geido removed the hold! On hold label Nov 25, 2024
@geido geido merged commit ba99980 into apache:master Nov 25, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 preset:bounty Issues that have been selected by Preset and have a bounty attached. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ant Design 5: Upgrade List component
3 participants