chore(Tooltip): Upgrade Tooltip to Ant Design 5 #31182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
changed the title
sadpandajoe
added
review:checkpoint
alexandrusoare
requested review from
jinghua-qa,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
dosubot
bot
added
change:frontend
|
Thanks for the PR. I just submitted a small commit to clean up a few things |
geido
added
the
preset:bounty
geido
force-pushed
the
alexandrusoare/refactor/antd5-tooltip
branch
from
058b6c1 to
19f6510
Compare
geido
reviewed
Nov 29, 2024
| const theme = useTheme(); | ||
| const defaultColor = `${theme.colors.grayscale.dark2}e6`; | ||
| return ( | ||
| <> | ||
| {/* Safari hack to hide browser default tooltips */} |
There was a problem hiding this comment.
It seems that this hack isn't working anymore anyways
geido
approved these changes
Nov 29, 2024
geido
force-pushed
the
alexandrusoare/refactor/antd5-tooltip
branch
from
19f6510 to
d31f271
Compare
michael-s-molina
removed
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31020
SUMMARY
Upgraded the Tooltip component from Ant4 to Antdv5
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
Before
After
Before
After
Before
After
Before
After
Before
After
Before
After
Before
After
Before
After
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION