fix: master docker builds fail because of multi-platform builds can't --load #31493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… --load Fixing an issue in `master` related to the fact that we do multi-platform build on master and not on PRs (PR succeeded, but failed on master since the --load directive doesn't work against multi-platform here removing load and doing a `docker pull`)
github-actions
bot
added
the
github_actions
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
betodealmeida
approved these changes
Dec 17, 2024
geido
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue in
masterrelated to the fact that we do multi-platform build on master andnot on PRs (PR succeeded, but failed on master since the --load directive doesn't work against multi-platform
here removing load and doing a
docker pull)NOTE: manually tested against multi-platform builds too so this should fix
mastertoo