Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore] make edit datasource a basic link #3244

Merged
merged 1 commit into from
Aug 8, 2017
Merged

[explore] make edit datasource a basic link #3244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions superset/assets/javascripts/explore/components/controls/DatasourceControl.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Table } from 'reactable';
import { Label, FormControl, Modal, OverlayTrigger, Tooltip } from 'react-bootstrap';

import ControlHeader from '../ControlHeader';
import InfoTooltipWithTrigger from '../../../components/InfoTooltipWithTrigger';

const propTypes = {
description: PropTypes.string,
Expand Down Expand Up @@ -95,18 +94,22 @@ export default class DatasourceControl extends React.PureComponent {
<Tooltip id={'error-tooltip'}>Click to point to another datasource</Tooltip>
}
>
<Label onClick={this.toggleModal} style={{ cursor: 'pointer' }} className="m-r-3">
<Label onClick={this.toggleModal} style={{ cursor: 'pointer' }} className="m-r-5">
{this.props.datasource.name}
</Label>
</OverlayTrigger>
<InfoTooltipWithTrigger
tooltip="edit the datasource's configuration"
icon="edit"
label="edit datasource"
onClick={() => {
window.location = this.props.datasource.edit_url;
}}
/>
<OverlayTrigger
placement="right"
overlay={
<Tooltip id={'edit-datasource-tooltip'}>
Edit the datasource's configuration
</Tooltip>
}
>
<a href={this.props.datasource.edit_url}>
<i className="fa fa-edit" />
</a>
</OverlayTrigger>
<Modal
show={this.state.showModal}
onHide={this.toggleModal}
Expand Down