Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sql lab] fix sluggish backspace in editor #3286

Merged
merged 1 commit into from
Aug 15, 2017
Merged

[sql lab] fix sluggish backspace in editor #3286

merged 1 commit into from
Aug 15, 2017

Commits on Aug 14, 2017

  1. [sql lab] fix sluggish backspace in editor 

    Somehow Ace's "changeSelection" event is triggered when hitting
backspace (and shouldn't!).

changeSelection on our side triggers enough work to make the
holding backspace sluggish and laggy.

This fix ignores selection with a length of 1, avoiding mutating the
state altogether when hitting/holding backspace.
    @mistercrunch
    mistercrunch committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    880b845 View commit details
    Browse the repository at this point in the history