-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing the timeout param from backend #3329
Conversation
Coverage remained the same at 69.397% when pulling 5abc0f690a7e02227d0e91155d56e3c53f04ced0 on mistercrunch:timeout_backend into 9f3aeb2 on apache:master. |
1 similar comment
Coverage remained the same at 69.397% when pulling 5abc0f690a7e02227d0e91155d56e3c53f04ced0 on mistercrunch:timeout_backend into 9f3aeb2 on apache:master. |
5abc0f6
to
cbd8cfd
Compare
A couple of late comments:
|
yup, I was going to make the same comment as @xrmx above - why is a default needed in the first place? |
2 - @andreineculau @xrmx it's a fixture for the unit test |
@mistercrunch Ah! missed the _spec in the name :) |
@mistercrunch I got the timeout in the slice panel. It seems that the default timeout in the runQuery is 60s and it is not synced with the timeout set in the superset_config.py. |
@maxsonic that's a default, the caller should be updated |
What's the value which the client will timeout regardless of it gets a web response set in superset_config.py ? |
const queryDuration = moment.duration(this.props.query.endDttm - this.props.query.startDttm); | ||
if (Math.round(queryDuration.asMilliseconds()) > QUERY_TIMEOUT_THRESHOLD) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can anyone tell which is the new constant supplanting QUERY_TIMEOUT_THRESHOLD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUPERSET_WEBSERVER_TIMEOUT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xrmx . why this name got changed ?
"Query timeout - visualization query are set to timeout at 60 seconds. Perhaps your data has grown, your database is under unusual load, or you are simply querying a data source that is to large to be processed within the timeout range. If that is the case, we recommend that you summarize your data further." please How to resolve the problem? I set SUPERSET_WEBSERVER_TIMEOUT=600 in superset_config.py,but It's not work。 |
Before, the client-side timeout was hard coded and not aligned with the backend's setting. You would have to recompile the JS bundle with a different value if you wanted to change it.
Now the value set in
superset_config.py
is sent to the client and the client will timeout regardless of it gets a web response or not.fixes #3030 (I think?)