Improved Datatables View (and some other minor improvements as well) #3375
Conversation
… and got the non metrics table sort of sorted
Conflicts: setup.py superset/assets/package.json superset/assets/stylesheets/superset.css superset/assets/visualizations/filter_box.jsx superset/assets/visualizations/table.js
Datatables scrolling
Conflicts: superset/assets/visualizations/table.js
Conflicts: superset/assets/visualizations/table.js
Malcolmflint vis improvements
1 similar comment
metadata.json
Outdated
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
What is this file needed for?
There was a problem hiding this comment.
My bad, that one snuck it's way in. I'll remove it. Just a sec
| @@ -61,7 +61,6 @@ | |||
| USER_MISSING_ERR = __("The user seems to have been deleted") | |||
There was a problem hiding this comment.
I'd drop all the changes to this file unless there's a good reason you need them
There was a problem hiding this comment.
the reason to go to appbuilder.sm.auth_view.login (line 2231) is so that if someone were to use OAuth and define their own security manager it doesn't get stuck in a redirect loop. With default authentication, I believe it works exactly the same.
superset/assets/package.json
Outdated
| @@ -54,6 +54,11 @@ | |||
| "datatables-bootstrap3-plugin": "^0.5.0", | |||
| "datatables.net": "^1.10.13", | |||
| "datatables.net-bs": "^1.10.12", | |||
| "datatables.net-buttons": "^1.3.1", | |||
| "datatables.net-buttons-bs": "^1.3.1", | |||
| "font-awesome": "^4.6.3", | |||
There was a problem hiding this comment.
I think we dropped this in favour of the fab shipped one.
There was a problem hiding this comment.
The comment is for font-awesome
There was a problem hiding this comment.
ah, I would be happy to remove the line provided it won't break anything. I'll do that now
| showMetricNumber: PropTypes.bool, | ||
| origSelectedValues: PropTypes.object, | ||
| instantFiltering: PropTypes.bool, | ||
| sliceId: PropTypes.number, |
There was a problem hiding this comment.
Are we actually using sliceId for something?
There was a problem hiding this comment.
It appears not. That was in there when I began work on the filter_box, so I added to prop_types for consistency...Let me know and I'll remove it from the entire file.
There was a problem hiding this comment.
If sliceId is not used no need to keep it.
2 similar comments
|
Notice: this issue has been closed because it has been inactive for 240 days. Feel free to comment and request for this issue to be reopened. |
During my time at Yahoo/Oath as an Intern, I made improvements to the datatables implementation in the table visualization. Most notably I was able to improve the scrolling as well as add an export to csv button that will export the filtered table. I also improved the speed of rendering the visualization in part by removing the last metric column if there are no metrics given.