Allow user update slice title in visualize flow #3466
Conversation
graceguo-supercat
changed the title
|
Coverage increased (+0.2%) to 69.164% when pulling da680e52f19fa94e15588444d03d6245d40d488f on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into ad604ae on apache:master. |
graceguo-supercat
force-pushed
the
gg-AllowUpdateTitleOnVisualize
branch
from
da680e5 to
3e9b3fd
Compare
|
Coverage remained the same at 69.168% when pulling 3e9b3fd797f08c5163462305b2c959349c48eec7 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into e399a8c on apache:master. |
| this.props.actions.updateChartTitle(newTitle); | ||
| .then((data) => { | ||
| if (isNewSlice) { | ||
| window.location = data; |
There was a problem hiding this comment.
Is a round trip necessary? As a user it may be confusing.
There was a problem hiding this comment.
after new slice is created, we render "favorite" and "edit slice properties" icon on top of the slice. For chart in visualize flow we don't show those icons.
Refresh page after save slice_name is just to render those icons.
After discussing with Max, i will change response for saveSlice to return json formatted data (with new slice id), and rerender newly-created slice without refresh.
… update slice title, and create a new slice at the same time. 2. don't save new title if it is empty. Will still show old title.
graceguo-supercat
force-pushed
the
gg-AllowUpdateTitleOnVisualize
branch
2 times, most recently
from
26fae09 to
5085203
Compare
|
Coverage remained the same at 69.535% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
3 similar comments
|
Coverage remained the same at 69.535% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
|
Coverage remained the same at 69.535% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
|
Coverage remained the same at 69.535% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
|
Coverage decreased (-0.1%) to 69.386% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
2 similar comments
|
Coverage decreased (-0.1%) to 69.386% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
|
Coverage decreased (-0.1%) to 69.386% when pulling 50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize into 9af34ba on apache:master. |
graceguo-supercat
force-pushed
the
gg-AllowUpdateTitleOnVisualize
branch
from
5085203 to
c696942
Compare
1 similar comment
* 1. after user make sql query and visualize, allow user click title to update slice title, and create a new slice at the same time. 2. don't save new title if it is empty. Will still show old title. * change saveSlice call response and update explore view
* 1. after user make sql query and visualize, allow user click title to update slice title, and create a new slice at the same time. 2. don't save new title if it is empty. Will still show old title. * change saveSlice call response and update explore view
mistercrunch
added
🏷️ bot
after user make sql query and visualize, allow user click title to update slice title, and create a new slice at the same time.
don't save new title if it is empty. When user click-out and title is not on focus, we will still show old title.