Druid refresh metadata performance improvements #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mogball
commented
Sep 25, 2017
Mogball
commented
- Requests to Druid for datasource metadata are now issued in parallel
- Some SQLA tweaks here and there
- Added an option to scan Druid only for new tables, instead of refreshing everything
xrmx
reviewed
Sep 26, 2017
| datasource.merge_flag = merge_flag | ||
| session.flush() | ||
|
|
||
| # Prepare multithreaded executation |
There was a problem hiding this comment.
nits: these are processes not threads. Q: Do you think this can be offloaded to celery instead of multiprocessing?
There was a problem hiding this comment.
Not a bad idea, though for now setting up celery isn't a hard requirement which helps people onboard without having to setup a MQ and workers...
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Oct 3, 2017
* parallelized refresh druid metadata * fixed code style errors * fixed code for python3 * added option to only scan for new druid datasources * Increased code coverage
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* parallelized refresh druid metadata * fixed code style errors * fixed code for python3 * added option to only scan for new druid datasources * Increased code coverage
This was referenced Jun 28, 2023
This was referenced Jul 6, 2023
This was referenced Dec 1, 2023
This was referenced Dec 27, 2023
This was referenced Jan 4, 2024
This was referenced Jan 12, 2024
This was referenced Jan 20, 2024
This was referenced Jan 31, 2024
This was referenced Feb 7, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.