-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate all translation config #3750
Consolidate all translation config #3750
Conversation
Move all translation config to superset/translations
If you get errors running `po2json`, you might be running the ubuntu package with the same | ||
name rather than the nodejs package (they have a different format for the arguments). You | ||
need to be running the nodejs version, and so if there is a conflict you may need to point | ||
directly at `/usr/local/bin/po2json` rather than just `po2json`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path would be valid only if you installed with npm install -g
. The package in debian / ubuntu looks the correct one to latest release 0.4.5 as we have in package.json. What was the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did install using npm install -g
, as that's what it currently recommends in CONTRIBUTING.md
. Should we update that to not recommend a global install?
I wonder if actually, I should update the docs here to add clarity around what needs to be done to makes sure po2json
is installed in the right place more broadly. I found the process quite fiddly for someone who doesn't use node very often - global vs local installs and what folder things are available in was at the root of that I think. I'd love to make the process as easy as:
- Run command X in folder Y to install Z.
- Run command A in folder B to convert messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It docs use global install then it's fine.
Thanks for adjusting this. Eventually we can wrap those in |
Move all translation config to superset/translations
Fixes #3745
Move all translation config to superset/translations, as suggested in the above issue. The
babel
folder which has been removed was being used as a default, hence the update to the docs to show that this now needs to be specified explicitly.