Making time table viz scrollable #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,7 @@ FormattedNumber.propTypes = { | |||
|
|
|||
| function viz(slice, payload) { | |||
| slice.container.css('height', slice.height()); | |||
| slice.container.css('overflow', 'scroll'); | |||
There was a problem hiding this comment.
why not set this style in css file, the container has a class...
|
Coverage remained the same at 71.445% when pulling a737c1613060c8aad67062128ba22570526ccbb5 on michellethomas:timetable_viz_scroll into 4fa1f0a on apache:master. |
1 similar comment
|
Coverage remained the same at 71.445% when pulling a737c1613060c8aad67062128ba22570526ccbb5 on michellethomas:timetable_viz_scroll into 4fa1f0a on apache:master. |
michellethomas
force-pushed
the
timetable_viz_scroll
branch
from
a737c16
to
9ff9a95
Compare
|
I'm not sure what the padding: 10px was set for, but it didn't seem to be getting applied correctly and it looks like too much padding. |
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously time table viz didn't scroll when given a large number of results.
Fixes #3802