[flake8] Resolving Q??? errors #3847
Conversation
john-bodley
force-pushed
the
john-bodley-flake8-Q
branch
2 times, most recently
from
ab21b5f
to
6d01b69
Compare
|
Agreed, single over double quotes. Personally I prefer switching to avoid backslashes but I feel bad making you make lots of edits. One thing though is that I prefer not enforcing rules that linters cannot enforce, so can we get pylint to enforce it? If not we'll have to tell each person on their first PR which is annoying both on the reviewer and reviewee side... |
|
Looks like this would do it: |
|
@mistercrunch I can switch from single to double quotes for the strings which include quotes to avoid backslashes. I'll comment on the PR when the change is made. |
|
Sweet that will be ideal. It's also consistent with how the JS linter is set up. |
|
Now you're in a serious position to win the "Most update on Github" trophy for this week |
|
@mistercrunch |
john-bodley
force-pushed
the
john-bodley-flake8-Q
branch
4 times, most recently
from
3b7251c
to
607d446
Compare
john-bodley
force-pushed
the
john-bodley-flake8-Q
branch
from
607d446
to
caaee0d
Compare
|
@mistercrunch I've update the PR to remove all occurrences of backslashes in the string. |
|
Woot! |
(cherry picked from commit ac57780)
| ) | ||
|
|
||
| @classmethod | ||
| def convert_dttm(cls, target_type, dttm): | ||
| tt = target_type.upper() | ||
| if tt == 'DATE': | ||
| return "'{}'".format(dttm.strftime('%Y-%m-%d')) | ||
| return "{}'".format(dttm.strftime('%Y-%m-%d')) |
| ) | ||
|
|
||
| @classmethod | ||
| def convert_dttm(cls, target_type, dttm): | ||
| tt = target_type.upper() | ||
| if tt == 'DATE': | ||
| return "'{}'".format(dttm.strftime('%Y-%m-%d')) | ||
| return "{}'".format(dttm.strftime('%Y-%m-%d')) |
Caused by apache#3847 Fixes apache#4915
Caused by apache#3847 Fixes apache#4915
Caused by apache#3847 Fixes apache#4915
Caused by apache#3847 Fixes apache#4915
mistercrunch
added
🏷️ bot
(cherry picked from commit 067596e)
This is the final PR related to remedying the flake8 errors. This resolves the flake8 Q??? violation errors which enforces single quotes for strings.
Previously there was a large mix of single and double quotes used for strings, and per PEP8,
it mentions to pick a rule and stick to it. Given that the majoring of strings were single-quoted I used that as the default. Note some strings include
'which I've escaped as opposed to using the other to avoid backslashes. I'm happy to remedy this if necessary.to: @mistercrunch