-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Druid post aggregations (continued) #410
Conversation
Conflicts: caravel/models.py caravel/views.py
Conflicts: caravel/models.py
|
|
|
Now aggregators are treated as if they are just normal metrics |
I did a little bit more work on this locally and wanted to basically define post aggs as metrics, using the DruidMetric model as opposed to a new model. Then it's just a matter of figuring out which metrics are post aggs and generating the write query. |
Do you mean you have another local branch in your machine that is similar to this pull request? Based on your old pull request or this request? Will you push your commit? Do I have to change anything in this PR or just wait for your commit? |
Opting for #418 instead of this PR |
Hi, this is still not so easy to use, but at least I can get the post aggregated average value using this now. It's at least another step forward.
This feature is very important to me and many others as you can see in the comments in the original pull requests ( #133 ).
Please consider merging it to the master if you think this is kind of ready. Or please give me feedbacks so I can make the whole feature work sooner.
Currently only TableViz is supported. If you think it looks good, I can add support to more other viz.
Thanks