[BugFix]: Creating a PostgresBaseEngineSpec so changes to the Postgre… #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmenges
force-pushed
the
fmenges/vertica_fix
branch
from
05cf800
to
8f5204c
Compare
…sEngineSpec don't affect every subclass
fabianmenges
force-pushed
the
fmenges/vertica_fix
branch
from
8f5204c
to
3ba94ec
Compare
fabianmenges
commented
Jan 17, 2018
|
@fabianmenges let me know when this is ready to merge |
|
This is ready to merge and also addresses a small part of #4230 |
xrmx
reviewed
Jan 18, 2018
superset/db_engine_specs.py
Outdated
| class PostgresBaseEngineSpec(BaseEngineSpec): | ||
| """ Abstract class for Postgres 'like' databases """ | ||
|
|
||
| engine = 'postgresqlbase' |
There was a problem hiding this comment.
Shouldn't this be empty (no engine attribute) so people extending it have to remember to add something sensible?
|
Ping, this is still required for Vertica support. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
apache#4224) * [BugFix]: Creating a PostgresBaseEngineSpec so changes to the PostgresEngineSpec don't affect every subclass * Empty engine for abstract Engine
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
apache#4224) * [BugFix]: Creating a PostgresBaseEngineSpec so changes to the PostgresEngineSpec don't affect every subclass * Empty engine for abstract Engine
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sEngineSpec don't affect every subclass
Refactored all classes that inherit from PostgresEngineSpec to inherit from PostgresBasesEngineSpec instead and moved them all to one place in the file.
#3856 Broke
get_table_namesfor Vertica and possibly Redshift and Oracle