[Sql Lab] Fix QueryAutoRefresh component pulling do not stop #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
@graceguo-supercat are we sure that this is right? I don't see anymore polling on our staging. Could be unrelated though, haven't dug to the bottom yet. |
|
Ran some tests and this breaks polling. We can talk about how we should timeout /cleanup old/dead queries in a way that would prevent hyperactive pooling. Reverting |
mistercrunch
added a commit
that referenced
this pull request
Jan 27, 2018
…)" This reverts commit 1c56319.
mistercrunch
added a commit
to mistercrunch/superset
that referenced
this pull request
Jan 27, 2018
|
Thanks for fixing it!~~ The problem bothered me is when query in current tab is stopped/succeeded, because of polling in other tabs, current results tab keeps re-rendering. My code change is not right fix. thanks! |
graceguo-supercat
pushed a commit
that referenced
this pull request
Jan 27, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 31, 2018
(cherry picked from commit f8dcbf7)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in SQL lab, the query results pulling doesn't stop.
@michellethomas @williaster