Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geo] JS function to receive the whole data array instead on individual objects #4262

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

mistercrunch
Copy link
Member

Moving from having the user define an interceptor function that operates
on one object at a time to passing the whole array.

By passing the entire array, it's possible to do multiple passes where
needed. A common pattern might be to figure out a max value of a prop in order
to define a scaler function. That's only possible if dealing with the
whole array.

No change management is necessary as this feature has not been officially released yet.

…al object

Moving from having the user define an interceptor function that operates
on one object at a time.

By passing the entire array, it's possible to do multiple pass where
needed. A common pattern might be to figure out the max value in order
to define a scaler function. That's only possible if dealing with the
whole array.
let jsFnMutator;
if (fd.js_datapoint_mutator) {
if (fd.js_data_mutator) {
Copy link
Member

@hughhhh hughhhh Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: later on we should have some type of baseComponentClass for the components so we aren't copying this condition into each layer.

What are your thoughts? @mistercrunch

@hughhhh
Copy link
Member

hughhhh commented Jan 23, 2018

🚢

@mistercrunch mistercrunch merged commit ff2f85f into apache:master Jan 24, 2018
@mistercrunch mistercrunch deleted the js_control_array branch January 24, 2018 21:16
mistercrunch added a commit that referenced this pull request Jan 27, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
…al object (apache#4262)

Moving from having the user define an interceptor function that operates
on one object at a time.

By passing the entire array, it's possible to do multiple pass where
needed. A common pattern might be to figure out the max value in order
to define a scaler function. That's only possible if dealing with the
whole array.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
…al object (apache#4262)

Moving from having the user define an interceptor function that operates
on one object at a time.

By passing the entire array, it's possible to do multiple pass where
needed. A common pattern might be to figure out the max value in order
to define a scaler function. That's only possible if dealing with the
whole array.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants