-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[druid] fix bug around handling NULLs #4358
Conversation
Note that Viz like the Sankey may use specific columns as a source but rename dataframe columns to |
superset/viz.py
Outdated
return ' NULL' | ||
if col: | ||
if col.is_string: | ||
return 'NULL' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space was added on purpose for having NULL entries before other values after sorting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha added it back
A more final solution (outside the scope of this bugfix PR) would be to get better at typing dataframes (currently we have a lot of |
fillna would miss out on identifying STRING columns for Druid and replace None in string columns with a numeric `0`. This mixed type column would confuse pandas down the line on some operations like `df.pivot_table`.
3cf2a93
to
ae4ca3a
Compare
fillna would miss out on identifying STRING columns for Druid and replace None in string columns with a numeric `0`. This mixed type column would confuse pandas down the line on some operations like `df.pivot_table`.
fillna would miss out on identifying STRING columns for Druid and replace None in string columns with a numeric `0`. This mixed type column would confuse pandas down the line on some operations like `df.pivot_table`.
fillna would miss out on identifying STRING columns for Druid and
replace None in string columns with a numeric
0
. Thismixed type column would confuse
pandas down the line on some operations like
df.pivot_table
.superseeds #4236
@xrmx 👀