Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make margin width based on container width instead of slice width #4487

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Make margin width based on container width instead of slice width #4487

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14f15b7
Make width based on container width instead of slice width
jeffreythewang Feb 26, 2018
7b3d434
fix const var name and add comment
jeffreythewang Feb 26, 2018
f6e678b
Actually 30 looks good too
jeffreythewang Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion superset/assets/visualizations/nvd3_vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import './nvd3_vis.css';
import { VIZ_TYPES } from './main';

const minBarWidth = 15;
// Limit on how large axes margins can grow as the chart window is resized
const maxMarginPad = 30;
const animationTime = 1000;

const BREAKPOINTS = {
Expand Down Expand Up @@ -463,7 +465,9 @@ function nvd3Vis(slice, payload) {

if (chart.yAxis !== undefined || chart.yAxis2 !== undefined) {
// Hack to adjust y axis left margin to accommodate long numbers
const marginPad = isExplore ? width * 0.01 : width * 0.03;
const containerWidth = slice.container.width();
const marginPad = Math.min(isExplore ? containerWidth * 0.01 : containerWidth * 0.03,
maxMarginPad);
const maxYAxisLabelWidth = chart.yAxis2 ? getMaxLabelSize(slice.container, 'nv-y1')
: getMaxLabelSize(slice.container, 'nv-y');
const maxXAxisLabelHeight = getMaxLabelSize(slice.container, 'nv-x');
Expand Down