[Bug Fix] Fix sqllab numpy array #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
force-pushed
the
fix_sqllab_np_array
branch
from
a29cca3
to
12caf65
Compare
Codecov Report
@@ Coverage Diff @@
## master #4629 +/- ##
==========================================
+ Coverage 71.22% 71.22% +<.01%
==========================================
Files 190 190
Lines 14880 14880
Branches 1098 1098
==========================================
+ Hits 10598 10599 +1
+ Misses 4279 4278 -1
Partials 3 3
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Mar 19, 2018
|
LGTM |
michellethomas
changed the title
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Fixing error with sqllab numpy array * Adding tests for failing sqllab data type
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Fixing error with sqllab numpy array * Adding tests for failing sqllab data type
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing some sqllab errors where results can't correctly be converted to a numpy array. This answer says that we can set
dtype=objectto allow numpy to hold anything.Added additional test that would error without this fix.
@john-bodley