[deck_multi] fixing issues with deck_multi #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4754 +/- ##
==========================================
+ Coverage 72.38% 72.38% +<.01%
==========================================
Files 205 205
Lines 15374 15396 +22
Branches 1182 1182
==========================================
+ Hits 11128 11145 +17
- Misses 4243 4248 +5
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Apr 4, 2018
| if (!slice.subSlicesLayers) { | ||
| slice.subSlicesLayers = {}; // eslint-disable-line no-param-reassign | ||
| } | ||
| const subSlicesLayers = {}; // eslint-disable-line no-param-reassign |
There was a problem hiding this comment.
You can remove the eslint comment here, no?
| const layer = layerGenerators[subsliceCopy.form_data.viz_type](subsliceCopy.form_data, data); | ||
| slice.subSlicesLayers[subsliceCopy.slice_id] = layer; // eslint-disable-line no-param-reassign | ||
| subSlicesLayers[subsliceCopy.slice_id] = layer; // eslint-disable-line no-param-reassign |
There was a problem hiding this comment.
Same here, eslint comment should not be necessary.
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 11, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [deck_multi] fixing issues with deck_multi * removing eslint comment
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [deck_multi] fixing issues with deck_multi * removing eslint comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [deck_multi] fixing issues with deck_multi * removing eslint comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deck_multicharts from the chart selector control