Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve controls layout for Table visualization #4767

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Improve controls layout for Table visualization #4767

merged 1 commit into from
Apr 6, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Apr 5, 2018 •
edited
Loading

  • expanding the relevant section by default
  • moving row_limit to both GROUP BY and NOT GROUPED BY sections
  • Move options to Style tab
  • Don't mix checkbox and Select on same row

before

screen shot 2018-04-05 at 11 03 13 am

## after

screen shot 2018-04-05 at 11 09 26 am

@codecov-io
Copy link

Codecov Report

Merging #4767 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4767      +/-   ##
==========================================
+ Coverage   72.59%   72.61%   +0.01%     
==========================================
  Files         205      205              
  Lines       15401    15401              
  Branches     1183     1183              
==========================================
+ Hits        11180    11183       +3     
+ Misses       4218     4215       -3     
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 39.25% <ø> (ø) ⬆️
...rset/assets/javascripts/explore/stores/visTypes.js 70.58% <ø> (ø) ⬆️
...ipts/explore/components/ControlPanelsContainer.jsx 91.3% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92230b8...3948d79. Read the comment docs.

betodealmeida
betodealmeida approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! <3

@mistercrunch mistercrunch merged commit 4f2c206 into apache:master Apr 6, 2018
@mistercrunch mistercrunch deleted the table_vis_layout branch April 6, 2018 23:19
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 11, 2018
@mistercrunch @hughhhh
Improve controls layout for Table visualization (apache#4767)
ea621c7
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Improve controls layout for Table visualization (apache#4767)
3585c88
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
@mistercrunch @timifasubaa
Improve controls layout for Table visualization (apache#4767)
b2d32b1
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Improve controls layout for Table visualization (apache#4767)
278bd5e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @codecov-io @betodealmeida