-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'pip install .' #4856
Fix 'pip install .' #4856
Conversation
Fix error : > flask-appbuilder 1.10.0 has requirement Flask-SQLAlchemy==2.1, > but you'll have flask-sqlalchemy 2.3.2 which is incompatible. > botocore 1.10.5 has requirement python-dateutil<2.7.0,>=2.1, but you'll > have python-dateutil 2.7.2 which is incompatible.
Codecov Report
@@ Coverage Diff @@
## master #4856 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 44 44
Lines 8534 8534
=======================================
Hits 6568 6568
Misses 1966 1966 Continue to review full report at Codecov.
|
@mistercrunch isn't the fix to resolve the version specified in the |
Probably because of https://github.com/apache/incubator-superset/blob/master/tox.ini#L29, if you install the requirements.txt first and then run For me if I try a simple |
@mistercrunch I'll try to triage the problem seeing as I introduced the regression. If we remove the dependency we'll also need to update |
@mistercrunch I tested the following in Python 2.7 and 3.6 and wasn't able to reproduce your issue:
|
@john-bodley but the point is that it doesn't work if you don't When you |
@mistercrunch sorry from the title it mentioned
I think your change is fine if you also remove the |
Yes what I was trying to get to is that
|
Per my last comment, I recommend removing the line from requirements.txt as it’s unused by Superset directly. |
* Fix 'pip install .' Fix error : > flask-appbuilder 1.10.0 has requirement Flask-SQLAlchemy==2.1, > but you'll have flask-sqlalchemy 2.3.2 which is incompatible. > botocore 1.10.5 has requirement python-dateutil<2.7.0,>=2.1, but you'll > have python-dateutil 2.7.2 which is incompatible. * remove flask-sqlalchemy==2.1 from reqs.txt
* Fix 'pip install .' Fix error : > flask-appbuilder 1.10.0 has requirement Flask-SQLAlchemy==2.1, > but you'll have flask-sqlalchemy 2.3.2 which is incompatible. > botocore 1.10.5 has requirement python-dateutil<2.7.0,>=2.1, but you'll > have python-dateutil 2.7.2 which is incompatible. * remove flask-sqlalchemy==2.1 from reqs.txt
* Fix 'pip install .' Fix error : > flask-appbuilder 1.10.0 has requirement Flask-SQLAlchemy==2.1, > but you'll have flask-sqlalchemy 2.3.2 which is incompatible. > botocore 1.10.5 has requirement python-dateutil<2.7.0,>=2.1, but you'll > have python-dateutil 2.7.2 which is incompatible. * remove flask-sqlalchemy==2.1 from reqs.txt
Fix error :