-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portuguese translation #4874
Portuguese translation #4874
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4874 +/- ##
===========================================
- Coverage 76.96% 59.11% -17.85%
===========================================
Files 44 372 +328
Lines 8534 23751 +15217
Branches 0 2758 +2758
===========================================
+ Hits 6568 14041 +7473
- Misses 1966 9695 +7729
- Partials 0 15 +15
Continue to review full report at Codecov.
|
I had a native Continental Portuguese speaker review the translations and he approves. We need this for a project going live on the 1st of July. Can we merge these translations? |
Unless i am missing something you haven't translated the json messages. |
I don't know how? I wish someone could just translate them and convert them into money for me and put them safely into a portfolio or something for me to see what I have and when it arrives? |
@xrmx please review & warn me if something is still missing. thanks for the support btw |
@xrmx if you could please review and merge we would appreciate it - we have a project going live on July 1 that needs this translation |
@nunohelibeires @claycrosby I don't speak portuguese and I'm not a committer :) |
Hey everyone - we could use this for our project as well. Any idea if and when it may be merged? |
@betodealmeida is a Portuguese-speaking committer :) |
Hi @betodealmeida - do you happen to have time to review this PR? For what it's worth, @mistercrunch, I asked a native Portuguese-speaker on my team review the translations. His feedback is that the ones in this PR are quite good. Thank you very much for submitting them, @nunohelibeires. I really appreciate your work! |
@betodealmeida do you have a spare min to review this PR ? Thanks :) |
Sorry for the delay, will review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you for putting the effort in doing this translation! I have a few comments, and there are a few cases where %s
is written as % s
, other than that it should be good to go!
#: superset/assets/javascripts/explore/stores/visTypes.js:529 | ||
#: superset/viz.py:674 | ||
msgid "Box Plot" | ||
msgstr "Parcela" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This translation seems weird to me. Do people actually say "parcela" to refer to a box plot? I did a quick Google and people seemed to just use "Box plot" in portuguese.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. Box plot is the most used term.
|
||
#: superset/viz.py:1216 | ||
msgid "Can't have overlap between Series and Breakdowns" | ||
msgstr "Não pode haver sobreposição entre Series e Desagregação" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Séries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, thanks
#: superset/assets/javascripts/explore/stores/visTypes.js:96 | ||
#: superset/viz.py:1205 | ||
msgid "Distribution - Bar Chart" | ||
msgstr "Distribuição - Gráfico de barras" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gráfico de Barras
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, changed
#: superset/assets/javascripts/explore/stores/visTypes.js:868 | ||
#: superset/viz.py:1437 | ||
msgid "World Map" | ||
msgstr "Mapa Mundo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapa-Múndi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although no one uses the term verbally around here, Mapa-Múndi is the correct form. Nice.
|
||
#: superset/viz.py:1662 | ||
msgid "Choice of [Label] must be present in [Group By]" | ||
msgstr "A escolha da [Label] deve estar presente em []" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A escolha da [Label] deve estar presente em [Agrupar por]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should we use "Etiqueta" for "Label"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well thinking about this one again now, I also don't like "Etiqueta" for "Label".
What about "Rótulo" @betodealmeida , I think it is used more for this situation no?
"text box" | ||
msgstr "" | ||
|
||
#: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Gráfico de Queijo"?
"text box" | ||
msgstr "" | ||
|
||
#: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Ligação predefinida, é possível incluir {{ metric }} ou outros valores "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected
"text box" | ||
msgstr "" | ||
|
||
#: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Selecionar [%s]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected
"text box" | ||
msgstr "" | ||
|
||
#: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Bem vindo!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Let me know if you want to add a custom logo or welcome message, I can point out how we do it in my company.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed. Well, I changed the config.py for app name & icon. If any other customization is possible yes, please let me know ;)
#: superset/views/sql_lab.py:53 | ||
#, fuzzy | ||
msgid "Label" | ||
msgstr "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Etiqueta"? There are some more messages below where "Label" is translated as "Etiqueta", and some others were it's left unstranslated.
Thank you for the review @betodealmeida , I commented all your reviews and suggestions, changed the .po file and uploaded the correspondent .mo and json file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Hi everyone, thanks for getting this together. When can we expect it to be incorporated into the next update, and when can we expect to be able to make that update? |
@mistercrunch Everything reviewed thanks to @betodealmeida , I think this one is ready. |
Hi team, I see this was merged to master a few weeks ago but I'm not seeing it in the recent v27 update. Is it coming out in v28? |
@csc5k indeed it is only in the v0.28 branch. |
* Create message.po * Add files via upload * Update config.py * Update config.py * portuguese translation - messages.json po2json * Update message.po * Add files via upload * Add files via upload
Reopening #4605 with clean set of commits