Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation #4874

Merged
merged 8 commits into from
Aug 2, 2018
Merged

Portuguese translation #4874

merged 8 commits into from
Aug 2, 2018

Conversation

nunohelibeires
Copy link
Contributor

Reopening #4605 with clean set of commits

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #4874 into master will decrease coverage by 17.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4874       +/-   ##
===========================================
- Coverage   76.96%   59.11%   -17.85%     
===========================================
  Files          44      372      +328     
  Lines        8534    23751    +15217     
  Branches        0     2758     +2758     
===========================================
+ Hits         6568    14041     +7473     
- Misses       1966     9695     +7729     
- Partials        0       15       +15
Impacted Files Coverage Δ
superset/config.py 92.53% <ø> (+0.22%) ⬆️
superset/sql_lab.py 71.6% <0%> (-3.96%) ⬇️
superset/dataframe.py 94.49% <0%> (-3.21%) ⬇️
superset/viz.py 77.41% <0%> (-2.47%) ⬇️
superset/views/core.py 73.37% <0%> (-1.32%) ⬇️
superset/models/core.py 85.98% <0%> (-0.57%) ⬇️
superset/views/utils.py 93.93% <0%> (ø) ⬆️
superset/db_engines/hive.py 0% <0%> (ø) ⬆️
superset/connectors/base/views.py 81.81% <0%> (ø) ⬆️
superset/cache_util.py 54.16% <0%> (ø) ⬆️
... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7193a47...f8fb864. Read the comment docs.

@csc5k
Copy link

csc5k commented Jun 18, 2018

I had a native Continental Portuguese speaker review the translations and he approves. We need this for a project going live on the 1st of July.

Can we merge these translations?

@xrmx
Copy link
Contributor

xrmx commented Jun 18, 2018

Unless i am missing something you haven't translated the json messages.

@mzangie
Copy link

mzangie commented Jun 18, 2018

I don't know how? I wish someone could just translate them and convert them into money for me and put them safely into a portfolio or something for me to see what I have and when it arrives?

@nunohelibeires
Copy link
Contributor Author

nunohelibeires commented Jun 19, 2018

@xrmx please review & warn me if something is still missing. thanks for the support btw

@csc5k
Copy link

csc5k commented Jun 20, 2018

@xrmx if you could please review and merge we would appreciate it - we have a project going live on July 1 that needs this translation

@xrmx
Copy link
Contributor

xrmx commented Jun 20, 2018

@nunohelibeires @claycrosby I don't speak portuguese and I'm not a committer :)

@benleibert
Copy link

Hey everyone - we could use this for our project as well. Any idea if and when it may be merged?

@mistercrunch
Copy link
Member

@betodealmeida is a Portuguese-speaking committer :)

@benleibert
Copy link

Hi @betodealmeida - do you happen to have time to review this PR?

For what it's worth, @mistercrunch, I asked a native Portuguese-speaker on my team review the translations. His feedback is that the ones in this PR are quite good. Thank you very much for submitting them, @nunohelibeires. I really appreciate your work!

@nunohelibeires
Copy link
Contributor Author

@betodealmeida do you have a spare min to review this PR ? Thanks :)

@betodealmeida
Copy link
Member

Sorry for the delay, will review it.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you for putting the effort in doing this translation! I have a few comments, and there are a few cases where %s is written as % s, other than that it should be good to go!

#: superset/assets/javascripts/explore/stores/visTypes.js:529
#: superset/viz.py:674
msgid "Box Plot"
msgstr "Parcela"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation seems weird to me. Do people actually say "parcela" to refer to a box plot? I did a quick Google and people seemed to just use "Box plot" in portuguese.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. Box plot is the most used term.


#: superset/viz.py:1216
msgid "Can't have overlap between Series and Breakdowns"
msgstr "Não pode haver sobreposição entre Series e Desagregação"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Séries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks

#: superset/assets/javascripts/explore/stores/visTypes.js:96
#: superset/viz.py:1205
msgid "Distribution - Bar Chart"
msgstr "Distribuição - Gráfico de barras"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gráfico de Barras

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, changed

#: superset/assets/javascripts/explore/stores/visTypes.js:868
#: superset/viz.py:1437
msgid "World Map"
msgstr "Mapa Mundo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapa-Múndi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although no one uses the term verbally around here, Mapa-Múndi is the correct form. Nice.


#: superset/viz.py:1662
msgid "Choice of [Label] must be present in [Group By]"
msgstr "A escolha da [Label] deve estar presente em []"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A escolha da [Label] deve estar presente em [Agrupar por]"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should we use "Etiqueta" for "Label"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thinking about this one again now, I also don't like "Etiqueta" for "Label".

What about "Rótulo" @betodealmeida , I think it is used more for this situation no?

"text box"
msgstr ""

#:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Gráfico de Queijo"?

"text box"
msgstr ""

#:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ligação predefinida, é possível incluir {{ metric }} ou outros valores "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

"text box"
msgstr ""

#:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Selecionar [%s]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

"text box"
msgstr ""

#:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bem vindo!"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Let me know if you want to add a custom logo or welcome message, I can point out how we do it in my company.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed. Well, I changed the config.py for app name & icon. If any other customization is possible yes, please let me know ;)

#: superset/views/sql_lab.py:53
#, fuzzy
msgid "Label"
msgstr "Label"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Etiqueta"? There are some more messages below where "Label" is translated as "Etiqueta", and some others were it's left unstranslated.

@nunohelibeires
Copy link
Contributor Author

nunohelibeires commented Jul 24, 2018

Thank you for the review @betodealmeida , I commented all your reviews and suggestions, changed the .po file and uploaded the correspondent .mo and json file.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@csc5k
Copy link

csc5k commented Jul 30, 2018

Hi everyone, thanks for getting this together. When can we expect it to be incorporated into the next update, and when can we expect to be able to make that update?

@nunohelibeires
Copy link
Contributor Author

@mistercrunch Everything reviewed thanks to @betodealmeida , I think this one is ready.
Do you think it can be merged and ready for the next vers?

@mistercrunch mistercrunch merged commit 0786913 into apache:master Aug 2, 2018
@csc5k
Copy link

csc5k commented Aug 22, 2018

Hi team, I see this was merged to master a few weeks ago but I'm not seeing it in the recent v27 update. Is it coming out in v28?

@nunohelibeires
Copy link
Contributor Author

@csc5k indeed it is only in the v0.28 branch.
probably this PR was merged only after the creation of the v0.27 branch.

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Create message.po

* Add files via upload

* Update config.py

* Update config.py

* portuguese translation - messages.json

po2json

* Update message.po

* Add files via upload

* Add files via upload
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants