Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement schema uri insertion for Snowflake #5474

Closed
wants to merge 1 commit into from
Closed

Implement schema uri insertion for Snowflake #5474

wants to merge 1 commit into from

Conversation

villebro
Copy link
Member

SQL Lab queries weren't passing the selected schema into Snowflake URI, forcing the user to either define the schema in the connection string or prefixed before the table name.

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #5474 into master will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5474      +/-   ##
=========================================
- Coverage   59.11%   59.1%   -0.02%     
=========================================
  Files         372     372              
  Lines       23751   23759       +8     
  Branches     2758    2758              
=========================================
+ Hits        14041   14043       +2     
- Misses       9695    9701       +6     
  Partials       15      15
Impacted Files Coverage Δ
superset/db_engine_specs.py 52.9% <25%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea0a0a...b951434. Read the comment docs.

@villebro
Copy link
Member Author

@mistercrunch any chance to get this merged? Would help in testing #5487

@villebro
Copy link
Member Author

Logic moved to #5474 .

@villebro villebro closed this Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants