[sql lab] simplify the visualize flow #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, here's a list of issues: * it's not really clear to users that their query is wrapped as a subquery, and the explore view runs queries on top of it
mistercrunch
force-pushed
the
viz_flow
branch
2 times, most recently
from
706242c to
009028d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5523 +/- ##
==========================================
- Coverage 63.29% 63.14% -0.15%
==========================================
Files 349 349
Lines 22151 22124 -27
Branches 2459 2452 -7
==========================================
- Hits 14020 13970 -50
- Misses 8117 8140 +23
Partials 14 14
Continue to review full report at Codecov.
|
mistercrunch
changed the title
hughhhh
reviewed
Aug 1, 2018
| this.state = { | ||
| hints: [], | ||
| }; | ||
| this.visualize = this.visualize.bind(this); |
There was a problem hiding this comment.
nit: you can use autobind-decorators here
There was a problem hiding this comment.
We should introduce this decorator and attack the whole repo with it. In the meantime we have one less dependency and consistent-ish code (we have some binding done outside the constructors in many places...)
hughhhh
reviewed
Aug 1, 2018
| return datasourceName; | ||
| } | ||
| buildVizOptions() { | ||
| const { schema, sql, dbId, templateParams } = this.props.query; |
There was a problem hiding this comment.
nit:
return {
...this.props.query,
datasourceName: this.datasourceName(),
columns: this.getColumns(),
}
There was a problem hiding this comment.
There are lots of other keys in the query object we may not want to send over though :(
hughhhh
reviewed
Aug 1, 2018
superset/views/core.py
Outdated
| @@ -2201,8 +2202,9 @@ def sync_druid_source(self): | |||
| def sqllab_viz(self): | |||
| SqlaTable = ConnectorRegistry.sources['table'] | |||
| data = json.loads(request.form.get('data')) | |||
| from pprint import pprint | |||
| pprint(data) | |||
|
Nice, I really like the touch of the timeout dialog. |
|
@betodealmeida @hughhhh I addressed most comments |
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
* [sql lab] simplify the visualize flow The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, here's a list of issues: * it's not really clear to users that their query is wrapped as a subquery, and the explore view runs queries on top of it * lint + fix tests * Addressing comments (cherry picked from commit fe6846b)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
* [sql lab] simplify the visualize flow The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, here's a list of issues: * it's not really clear to users that their query is wrapped as a subquery, and the explore view runs queries on top of it * lint + fix tests * Addressing comments (cherry picked from commit fe6846b) (cherry picked from commit 5ba60d9)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sql lab] simplify the visualize flow The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, here's a list of issues: * it's not really clear to users that their query is wrapped as a subquery, and the explore view runs queries on top of it * lint + fix tests * Addressing comments
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, the current flow is heavy and unintuitive. Now that we have the
MetricsControlthere's less need to define the metrics upfront.This new flow sends the user straight to the explore view using the table view with all columns (not grouped)