[bugfix] TIMESTAMP not detected as date #5629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Aug 14, 2018
superset/dataframe.py
Outdated
| if dtype and dtype.name: | ||
| return any([ | ||
| dtype.name.startswith(s.lower()) | ||
| for s in ['date', 'time'] |
There was a problem hiding this comment.
Should we do dtype.name.startswith(s.lower().lstrip('_')) instead, to catch __time as a timestamp as well?
There was a problem hiding this comment.
oops, realized I was lowering the hard coded strings...
Codecov Report
@@ Coverage Diff @@
## master #5629 +/- ##
==========================================
+ Coverage 63.48% 63.49% +0.01%
==========================================
Files 360 360
Lines 22889 22887 -2
Branches 2547 2548 +1
==========================================
+ Hits 14531 14533 +2
+ Misses 8343 8339 -4
Partials 15 15
Continue to review full report at Codecov.
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 16, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 17, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 17, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 18, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 18, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 19, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 19, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 20, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 20, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak (cherry picked from commit 4c2be71)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [bugfix] TIMESTAMP not detected as date * minor tweak
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vylc @betodealmeida