Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories and time slider to arc deck.gl viz #5638

Merged
merged 3 commits into from
Aug 22, 2018

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 15, 2018

I added support for categorical colors in the arc deck.gl viz. I refactored the code that handles the categorization out of the scatter viz, and created a new component CategoricalDeckGLContainer. The component handles the interactive legend (toggling categories), as well as the play slider and the Javascript mutations.

screen shot 2018-08-15 at 12 30 06 pm

@codecov-io
Copy link

Codecov Report

Merging #5638 into master will increase coverage by 0.02%.
The diff coverage is 5.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5638      +/-   ##
==========================================
+ Coverage   63.51%   63.54%   +0.02%     
==========================================
  Files         360      361       +1     
  Lines       22890    22889       -1     
  Branches     2549     2547       -2     
==========================================
+ Hits        14539    14545       +6     
+ Misses       8336     8329       -7     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️
superset/assets/src/visualizations/Legend.jsx 0% <ø> (ø) ⬆️
...et/assets/src/visualizations/deckgl/layers/arc.jsx 0% <0%> (ø) ⬆️
...sualizations/deckgl/CategoricalDeckGLContainer.jsx 0% <0%> (ø)
...ssets/src/visualizations/deckgl/layers/scatter.jsx 0% <0%> (ø) ⬆️
superset/viz.py 81.33% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5966a67...7229b60. Read the comment docs.

@hughhhh hughhhh self-requested a review August 17, 2018 23:24
@mistercrunch mistercrunch merged commit 6959b70 into apache:master Aug 22, 2018
@mistercrunch
Copy link
Member

LGTM

kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 11, 2018
* Fix legend position

* Add categories and play slider to arc viz

* New functionality to arc viz

(cherry picked from commit 6959b70)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Fix legend position

* Add categories and play slider to arc viz

* New functionality to arc viz
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants