[SIP-5] Repair and refactor Word Cloud #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
force-pushed
the
kristw/word-cloud
branch
from
b515f9a
to
007237d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5669 +/- ##
==========================================
- Coverage 63.49% 63.47% -0.02%
==========================================
Files 360 360
Lines 22910 22916 +6
Branches 2551 2550 -1
==========================================
Hits 14547 14547
- Misses 8348 8354 +6
Partials 15 15
Continue to review full report at Codecov.
|
williaster
reviewed
Aug 20, 2018
| }; | ||
|
|
||
| const propTypes = { | ||
| data: PropTypes.array, |
There was a problem hiding this comment.
could we add arrayOf with a more specific PropTypes.shape({ size: PropTypes.number, text: PropTypes.string }) here? (I think that's the shape)
There was a problem hiding this comment.
sure. Thanks for catching.
kristw
force-pushed
the
kristw/word-cloud
branch
from
1870b05
to
bd04e1e
Compare
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 22, 2018
* create reactize function * update function signature * adjust word cloud controls * Fix broken word cloud logic * Repair and refactor word cloud * remove file * Add PropTypes * change module.exports to export default * change order * update proptypes (cherry picked from commit 0a40149)
kristw
changed the title
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* create reactize function * update function signature * adjust word cloud controls * Fix broken word cloud logic * Repair and refactor word cloud * remove file * Add PropTypes * change module.exports to export default * change order * update proptypes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderTriggerfor the optionssliceandformData@williaster @graceguo-supercat @conglei