Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force quoted column aliases for Oracle-like databases #5686

Merged
merged 29 commits into from
Sep 4, 2018
Merged

Force quoted column aliases for Oracle-like databases #5686

merged 29 commits into from
Sep 4, 2018

Commits on Aug 25, 2018

  1. Replace dataframe label override logic with table column override

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    d5242d0 View commit details
    Browse the repository at this point in the history

  2. Add mutation to any_date_col

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    ead1b55 View commit details
    Browse the repository at this point in the history

  3. Linting

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    4540d11 View commit details
    Browse the repository at this point in the history

  4. Add mutation to oracle and redshift

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    027f794 View commit details
    Browse the repository at this point in the history

  5. Fine tune how and which labels are mutated

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    f8f851a View commit details
    Browse the repository at this point in the history

  6. Implement alias quoting logic for oracle-like databases

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    ce3617b View commit details
    Browse the repository at this point in the history

  7. Fix and align column and metric sqla_col methods

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    5f67d59 View commit details
    Browse the repository at this point in the history

  8. Clean up typos and redundant logic

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    8b6e52d View commit details
    Browse the repository at this point in the history

  9. Move new attribute to old location

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    62163fa View commit details
    Browse the repository at this point in the history

  10. Linting

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    e8dd7da View commit details
    Browse the repository at this point in the history

  11. Replace old sqla_col property references with function calls

    @villebro
    villebro committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    6c6436f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2018

  1. Remove redundant calls to mutate_column_label

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    4b0e593 View commit details
    Browse the repository at this point in the history

  2. Move duplicated logic to common function

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    76959dd View commit details
    Browse the repository at this point in the history

  3. Add db_engine_specs to all sqla_col calls

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    6c7fccc View commit details
    Browse the repository at this point in the history

  4. Add missing mydb

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    c187104 View commit details
    Browse the repository at this point in the history

  5. Add note about snowflake-sqlalchemy regression

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    53b77a2 View commit details
    Browse the repository at this point in the history

  6. Make db_engine_spec mandatory in sqla_col

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    e792d15 View commit details
    Browse the repository at this point in the history

  7. Small refactoring and cleanup

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    44eac83 View commit details
    Browse the repository at this point in the history

  8. Remove db_engine_spec from get_from_clause call

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    a161efc View commit details
    Browse the repository at this point in the history

  9. Make db_engine_spec mandatory in adhoc_metric_to_sa

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    901b635 View commit details
    Browse the repository at this point in the history

  10. Remove redundant mutate_expression_label call

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    7e7a2a8 View commit details
    Browse the repository at this point in the history

  11. Add missing db_engine_specs to adhoc_metric_to_sa

    @villebro
    villebro committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    d60ed34 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. Rename arg label_name to label in get_column_label()

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    fc2c4f2 View commit details
    Browse the repository at this point in the history

  2. Rename label function and add docstring

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    3f2d874 View commit details
    Browse the repository at this point in the history

  3. Remove redundant db_engine_spec args

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    95c99d3 View commit details
    Browse the repository at this point in the history

  4. Rename col_label to label

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    04d3b5f View commit details
    Browse the repository at this point in the history

  5. Remove get_column_name wrapper and make direct calls to db_engine_spec

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    efb6313 View commit details
    Browse the repository at this point in the history

  6. Remove unneeded db_engine_specs

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    3a6fe4b View commit details
    Browse the repository at this point in the history

  7. Rename sa_ vars to sqla_

    @villebro
    villebro committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    0d18163 View commit details
    Browse the repository at this point in the history