[bugfix] Encode unicode error message response #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
force-pushed
the
fix_errors_response
branch
from
59a9b51
to
ad4c25f
Compare
zhaoyongjie
changed the title
zhaoyongjie
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5687 +/- ##
==========================================
- Coverage 63.49% 63.49% -0.01%
==========================================
Files 360 360
Lines 22914 22934 +20
Branches 2551 2555 +4
==========================================
+ Hits 14550 14562 +12
- Misses 8349 8357 +8
Partials 15 15
Continue to review full report at Codecov.
|
superset/views/base.py
Outdated
| @@ -45,7 +45,7 @@ def get_error_msg(): | |||
|
|
|||
| def json_error_response(msg=None, status=500, stacktrace=None, payload=None, link=None): | |||
| if not payload: | |||
| payload = {'error': str(msg)} | |||
| payload = {'error': msg.encode('utf-8')} | |||
There was a problem hiding this comment.
I don't think that is py3 compatible, go with '{}'.format(msg)
There was a problem hiding this comment.
@mistercrunch Thank you for reminding. updated commit
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Fix unicode error message response * Update
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When response error is unicode object, raise UnicodeEncodeError