[bugfix] geohash lat/long is reversed #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows support for reversing geohashes. Note that the default option was the wrong way.
Codecov Report
@@ Coverage Diff @@
## master #5695 +/- ##
==========================================
- Coverage 63.49% 63.48% -0.02%
==========================================
Files 360 360
Lines 22934 22941 +7
Branches 2555 2555
==========================================
+ Hits 14562 14564 +2
- Misses 8357 8362 +5
Partials 15 15
Continue to review full report at Codecov.
|
superset/viz.py
Outdated
| if spatial.get('reverseCheckbox'): | ||
| df[key] = [ | ||
| tuple(reversed(o)) if isinstance(o, (list, tuple)) else (0, 0) |
There was a problem hiding this comment.
I'm happy we're getting rid of the (0, 0) here.
There was a problem hiding this comment.
yeah that place on the west coast of africa that throws the autozoom off...
superset/viz.py
Outdated
| latlong.apply(lambda x: x[1]))) | ||
| df[key] = df[spatial.get('geohashCol')].map(geohash.decode) | ||
| if not spatial.get('reverseCheckbox'): | ||
| reverse_latlong() |
There was a problem hiding this comment.
This if block is super confusing... can't we fix geohash.decode instead?
There was a problem hiding this comment.
I can wrap it in a lambda that reverses it
mistercrunch
force-pushed
the
fix_geohash
branch
from
76ada94
to
570ef70
Compare
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [bugfix] geohash lat/long is reversed This allows support for reversing geohashes. Note that the default option was the wrong way. * addressing comments * make reverse_geohash_decode a staticmethod
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows support for reversing geohashes. Note that the default option was the wrong way.
