Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable input when IS (NOT) NULL selected #5766

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Disable input when IS (NOT) NULL selected #5766

merged 1 commit into from
Aug 29, 2018

Conversation

betodealmeida
Copy link
Member

Disable the input, since we shouldn't have a value.

screen shot 2018-08-28 at 3 40 21 pm

@betodealmeida betodealmeida mentioned this pull request Aug 28, 2018
Merged
@codecov-io
Copy link

Codecov Report

Merging #5766 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5766      +/-   ##
==========================================
+ Coverage   63.34%   63.34%   +<.01%     
==========================================
  Files         364      364              
  Lines       23051    23052       +1     
  Branches     2565     2566       +1     
==========================================
+ Hits        14602    14603       +1     
  Misses       8434     8434              
  Partials       15       15
Impacted Files Coverage Δ
...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx 79.36% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6ea37...87b04fc. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM!

@betodealmeida betodealmeida merged commit 48d220c into apache:master Aug 29, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
7fce232 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
02a28d3 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
5aa87a7 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
48ddc67 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
deb18cc 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
ad77956 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
4ef2ad8 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
e9f10ee 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
a117c36 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
e9c6d05 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
9fbd46c 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
590c9bb 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
44b0c4f 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
6b16c6e 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
c069ee2
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
67572c5 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
5ab6862 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
22d3533 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
3002e9c 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
c44d0a7 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
331102d 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
a518d61 
(cherry picked from commit 48d220c)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@betodealmeida @mistercrunch
Disable input when IS (NOT) NULL selected in filters (apache#5766)
ee9b9cb 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
1ba91a4 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
1ed369c 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
51e0ccd 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
e1780b8 
(cherry picked from commit 48d220c)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
4592c62 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
c452b75 
(cherry picked from commit 48d220c)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@betodealmeida @youngyjd
Disable input when IS (NOT) NULL selected in filters (apache#5766)
44f1411 
(cherry picked from commit 48d220c)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@betodealmeida
Disable input when IS (NOT) NULL selected in filters (apache#5766)
8af5a11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betodealmeida @codecov-io @mistercrunch