Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve categorical color management #5815

Merged
merged 33 commits into from
Sep 12, 2018
Merged

Improve categorical color management #5815

merged 33 commits into from
Sep 12, 2018

Commits on Sep 12, 2018

  1. Create new classes for handling categorical colors

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    3c1210c View commit details
    Browse the repository at this point in the history

  2. verify to pass existing unit tests

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    385a21a View commit details
    Browse the repository at this point in the history

  3. separate logic for forcing color and getting color

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1502fcb View commit details
    Browse the repository at this point in the history

  4. replace getColorFromScheme with CategoricalColorManager

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1fc211d View commit details
    Browse the repository at this point in the history

  5. organize static functions

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e3ddbd5 View commit details
    Browse the repository at this point in the history

  6. migrate to new function

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    dd60dc7 View commit details
    Browse the repository at this point in the history

  7. Remove ALL_COLOR_SCHEMES

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    211a777 View commit details
    Browse the repository at this point in the history

  8. move sequential colors to another file

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    c1aeeb5 View commit details
    Browse the repository at this point in the history

  9. extract categorical colors to separate file

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    56f9ef3 View commit details
    Browse the repository at this point in the history

  10. move airbnb and lyft colors to separate files

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f3671c8 View commit details
    Browse the repository at this point in the history

  11. fix missing toFunction()

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9894368 View commit details
    Browse the repository at this point in the history

  12. Rewrite to support local and global force items, plus namespacing.

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    943ecac View commit details
    Browse the repository at this point in the history

  13. fix references

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    3300080 View commit details
    Browse the repository at this point in the history

  14. revert nvd3

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    2efac2e View commit details
    Browse the repository at this point in the history

  15. update namespace api

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1515f05 View commit details
    Browse the repository at this point in the history

  16. Update the visualizations

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    cd48bd6 View commit details
    Browse the repository at this point in the history

  17. update usage with static functions

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    2915afc View commit details
    Browse the repository at this point in the history

  18. update unit test

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    d60d4ee View commit details
    Browse the repository at this point in the history

  19. add unit test

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f456065 View commit details
    Browse the repository at this point in the history

  20. rename default namespace

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    75318f4 View commit details
    Browse the repository at this point in the history

  21. add unit test for color namespace

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9d457a0 View commit details
    Browse the repository at this point in the history

  22. add unit test for namespace

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    00d8090 View commit details
    Browse the repository at this point in the history

  23. start unit test for colorschememanager

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8a91c4d View commit details
    Browse the repository at this point in the history

  24. add unit tests for color scheme manager

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    47c5f20 View commit details
    Browse the repository at this point in the history

  25. check returns for chaining

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e2dba45 View commit details
    Browse the repository at this point in the history

  26. complete unit test for the new classes

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    500f441 View commit details
    Browse the repository at this point in the history

  27. fix color tests

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1312dd5 View commit details
    Browse the repository at this point in the history

  28. update unit tests

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9dbccd6 View commit details
    Browse the repository at this point in the history

  29. update unit tests

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    d08be39 View commit details
    Browse the repository at this point in the history

  30. move color scheme registration to common

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    06970de View commit details
    Browse the repository at this point in the history

  31. update unit test

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    527e244 View commit details
    Browse the repository at this point in the history

  32. rename sharedForcedColors to parentForcedColors

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1cb5d61 View commit details
    Browse the repository at this point in the history

  33. remove import

    @kristw
    kristw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1cf4695 View commit details
    Browse the repository at this point in the history